update createAsyncTransform to allow for different node types#708
Merged
update createAsyncTransform to allow for different node types#708
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 502 503 +1
Lines 25643 25660 +17
Branches 2624 2630 +6
=======================================
+ Hits 22275 22292 +17
Misses 3045 3045
Partials 323 323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KetanReddy
reviewed
Aug 27, 2025
Member
|
Looks good! Just one small think about mocking in tests. |
tmarmer
force-pushed
the
async-transform-node-types
branch
from
0ff494d to
181e4ff
Compare
KetanReddy
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
createAsyncTransformutil to consider different incoming node types coming fromgetNestedAssetoption. Originally, this assumed that it would always be anassetnode type and would asset-wrap the node, but to allow for some additional flexibility, the following rules are applied: